I meet very few people who end up regretting their military service, even those who enlisted for the wrong reasons and decide to get out at the end of their first tour. Even know a few people who have been blown up a few times in Afghanistan/Iraq, and they don't regret their decision to enlist.
The question is always what you are going to do with your decisions in life. The military, as a career, may not be right for you. That doesn't mean the four years in will be a waste of time, however. It's an experience unlike what you are going to find in any other line of work, and the military is one of the few institutions which teaches leadership, anymore.
You can find managers everywhere - people who know how to work a spreadsheet and a calculator to twist hours and schedules to satisfy the formula. Leadership, on the other hand, is a very different thing. There are a hundred managers who would have their employees walk out on them to every one manager who can lead a crew through the hell of corporate accounting practices. Leadership is about building people up and seeing them off to pursue their potential. It's about training your replacement for when you leave, rather than squandering tips and tricks to protect your standing in the hierarchy. It's about arguing to see your employee promoted to a position above your own when they are qualified for it. It's about developing their skills and abilities to exceed your own and building a team that will work together to solve tasks rather than punch the clock.
I haven't really found a place in the civilian world which does that. A few places try to hold little workshops or symposiums filled with an incestuous group of academic do-nothings who like to try and tell people how to 'not bully in the work place' - but I've seen very few effective systems outside the military where leadership is taught. Even then - the military has lost some of its charm in that regard, though things have improved under Trump - people do not understand just how compromised and corrupt the military became under Obama, and how much pre-positioning had been done for it in the decades leading up to Obama's tenure.
So, I generally think that people will end up reflecting on their service in a positive light for the things they learned, even if they decide it isn't something they want to make a career out of. It can easily translate to a set of skills outside the military that distinguish you above and beyond the average person. Where they were taught to call for help, you were taught to be the help. Where they are taught to avoid danger, you are trained to engage it.
However, it isn't a decision to be made lightly. You do need to be committed to the decision and see your contract through. You're signing away a fair number of things that others will never let go of. While many people do not understand this President, and wrongly believe he is going to lead to war, there is still the possibility of war. You will likely be sent to that war. You may have friends you want to see, a wife you want to stay with, children you want to raise - but that war is where you are going. There are support groups and other such things for those back home - but it's still not a situation many would want. On the more mundane front, you'll be whipped around through the bureaucracy of the federal government. From base to base and locale to locale - some places very interesting, some extremely boring. Paperwork will get lost, you will hurry up to wait, and your pay might get inexplicably changed within the system and you'll discover it three months afterward, having to pay back the O-4 pay you were getting (or, maybe you lucked out and you get back-payed for money you should have gotten, but didn't).
Just be sure that your only motivation for enlisting isn't that you're upset or irritated that something else didn't go your way in the job/employment market.
That said, there are a lot of opportunities that will be opening up. Honestly, I wish I was born either a decade earlier, or a decade later than I was. The job market is opening up quite a bit, right now, and re-investment in American businesses and infrastructure is at a growth rate that simply hasn't been seen by anyone alive, today. It will take a bit of time to filter through the whole of the economy, but if you do get done with your tour, and decide you don't want to continue in the military, you'll likely find that you have an unprecedented number of options available to you.
To put it in context, the factory I am working at is looking at growing to 700 floor employees from 500 and doubling overall manufacturing capacity over the next three years. There is a steel mill setting up shop that will be looking to employ around 250 people. While the factory I work at is consumer goods - the steel mill is an infrastructure provider. That is going for steel in construction projects and new heavy industry. There is a mineral deposit in the state that is completely unexploited - a uranium, cobalt, rare earth, and gold deposit. Largest of its kind on the planet (known).
The world is about to be transformed as the systems put in place to keep humanity bound to the banking cartel and the parasitic caste of politicians are removed and nations become free to build their own economies. Things will get insane as the U.S. begins to provide for Chinese consumer demand. Mark my words - that is coming, and sooner than you think. Chinese factories can't keep up with our domestic demand, let alone their own as Chinese citizens begin to grow in wealth.
So, even if you don't pursue the military - there will still be plenty of opportunities available to you. For about the next year and a half, I know a place where you are pretty much guaranteed to be able to get a job, and probably one that will pay at least $15 an hour (or better, depending on what the cost of living does around here - need to get the tribal warlords out of office and ban-hammer the land barons).
